fix(wakuv2): logout / login delay #4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (4)
|
richard-ramos
force-pushed
the
fix/ctx-background
branch
from
aba80e8 to
76f55bc
Compare
richard-ramos
changed the title
vitvly
reviewed
Nov 17, 2023
| @@ -168,7 +168,8 @@ func (f *FiltersManager) InitCommunityFilters(communityFiltersToInitialize []Com | |||
| // TODO: requests to join / cancels are currently being sent into the default waku topic. | |||
| // They must be sent into an specific non protected shard | |||
| for _, pubsubTopic := range topics { | |||
| identityStr := PublicKeyToStr(&cf.PrivKey.PublicKey) | |||
| pk := &cf.PrivKey.PublicKey | |||
There was a problem hiding this comment.
So here, given that we're taking an address of loop variable cf, this pk param would always point to the same var, correct?
There was a problem hiding this comment.
yeah!
Earlier I updated golangci-lint on my machine and when I executed make lint saw a warning!
vitvly
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue described in status-im/status-mobile#17899 (comment) as well as reusing the IDService from go-waku instead of having status-go create its own, and also an error with a reference to a loop variable